change instances of alwaysparentsampler to parentorelse #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prondubuisi
requested review from
beniamin,
bobstrecansky and
morrisonlevi
as code owners
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=========================================
Coverage 90.97% 90.97%
Complexity 285 285
=========================================
Files 35 35
Lines 665 665
=========================================
Hits 605 605
Misses 60 60
Continue to review full report at Codecov.
|
bobstrecansky
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #174
references open-telemetry/opentelemetry-specification#609
Also renamed parentorelse to parentbased
references open-telemetry/opentelemetry-specification#610