Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #641 #642

Merged
merged 4 commits into from
Mar 30, 2022
Merged

Fix #641 #642

merged 4 commits into from
Mar 30, 2022

Conversation

saktib
Copy link
Contributor

@saktib saktib commented Mar 30, 2022

#641
Now the traceId and spanId are matching, and the same can be used to search the traces from Jaeger UI. [Functional Test]

traceId & spanId using otel lib
image

traceId & spanId from Jaeger Collector
image

Able to search with the traceId from Jaeger UI
image

@bobstrecansky
Copy link
Collaborator

I see a couple unit tests failing.

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #642 (879a645) into main (e62cd5e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 879a645 differs from pull request most recent head 83b9f18. Consider uploading reports for the commit 83b9f18 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #642      +/-   ##
============================================
- Coverage     84.45%   84.45%   -0.01%     
  Complexity     1141     1141              
============================================
  Files           127      127              
  Lines          2767     2766       -1     
============================================
- Hits           2337     2336       -1     
  Misses          430      430              
Flag Coverage Δ
7.4 84.40% <100.00%> (-0.01%) ⬇️
8.0 84.45% <100.00%> (-0.01%) ⬇️
8.1 84.45% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Contrib/Jaeger/IdConverter.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e62cd5e...83b9f18. Read the comment docs.

@saktib
Copy link
Contributor Author

saktib commented Mar 30, 2022

I see a couple unit tests failing.

@bobstrecansky I've fixed those now.

@bobstrecansky bobstrecansky merged commit aadcb12 into open-telemetry:main Mar 30, 2022
bobstrecansky pushed a commit that referenced this pull request Mar 31, 2022
was not removed in #642 along with the rest of the library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants