-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #641 #642
Fix #641 #642
Conversation
I see a couple unit tests failing. |
… between otel lib and jager collector
Codecov Report
@@ Coverage Diff @@
## main #642 +/- ##
============================================
- Coverage 84.45% 84.45% -0.01%
Complexity 1141 1141
============================================
Files 127 127
Lines 2767 2766 -1
============================================
- Hits 2337 2336 -1
Misses 430 430
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@bobstrecansky I've fixed those now. |
was not removed in #642 along with the rest of the library
#641
Now the traceId and spanId are matching, and the same can be used to search the traces from Jaeger UI. [Functional Test]
traceId & spanId using otel lib
traceId & spanId from Jaeger Collector
Able to search with the traceId from Jaeger UI