Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump protobuf extension to 3.20.0 #656

Merged
merged 1 commit into from
Apr 4, 2022
Merged

bump protobuf extension to 3.20.0 #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,10 @@ jobs:
strategy:
fail-fast: false
matrix:
php-version: ['7.4', '8.0']
php-version: ['7.4', '8.0', '8.1']
os: [ubuntu-latest]
extensions: ['ast, grpc', 'ast, grpc, protobuf']
extensions: ['ast, grpc', 'ast, grpc, protobuf-3.20.0']
experimental: [false]
include:
- php-version: 8.1
extensions: 'ast, grpc'
os: ubuntu-latest
experimental: true
- php-version: 8.1
extensions: 'ast, grpc, protobuf'
os: ubuntu-latest
experimental: true

steps:
- uses: actions/checkout@v2
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ A Google calendar invite with the included zoom link can be found [here](https:/
Our open issues can all be found in the [github issues tab](https://github.com/open-telemetry/opentelemetry-php/issues). Feel free to reach out on Slack if you have any additional questions about these issues; we are always happy to talk through implementation details.

## Requirements
The library requires a PHP version of 7.4.x or 8.0.x (PHP 8.1 compability is in the works)
The library requires a PHP version of 7.4.x, 8.0.x or 8.1.x

### Dependencies

Expand Down Expand Up @@ -91,7 +91,7 @@ Using fibers with non-`CLI` SAPIs may require pre-loading of bindings. One way t

** The PHP protobuf extension is optional when using either the `OTLPHttp` or `OTLPGrpc` exporters.**

The protobuf extension makes both exporters more performant. _Note: there are some deprecation warnings with protobuf and PHP 8.1_
The protobuf extension makes both exporters more performant. _Note that protobuf 3.20.0+ is required for php 8.1 support_

---

Expand Down