Add compliance test and annotate existing ones #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuktea
force-pushed
the
compliance-test-and-annotations
branch
3 times, most recently
from
c0bcfb3 to
0820860
Compare
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
============================================
+ Coverage 85.26% 85.28% +0.02%
+ Complexity 1153 1151 -2
============================================
Files 128 128
Lines 2789 2794 +5
============================================
+ Hits 2378 2383 +5
Misses 411 411
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yuktea
requested review from
bobstrecansky,
zsistla,
tidal and
brettmc
as code owners
|
All tests passing here. We could merge this first and rebase #670 before review. |
brettmc
reviewed
May 5, 2022
brettmc
reviewed
May 5, 2022
brettmc
reviewed
May 5, 2022
brettmc
reviewed
May 5, 2022
tests/Unit/SDK/Trace/SpanTest.php
Outdated
| $events = $span->toSpanData()->getEvents(); | ||
| $c = 0; | ||
|
|
||
| $this->assertEvent($events[$c++], 'a', new Attributes(), self::START_EPOCH); |
There was a problem hiding this comment.
I think this would be more readable if you just provided integer values.
There was a problem hiding this comment.
Agreed! I've pushed a9270a4 to improve readability here. Can you take a look?
yuktea
force-pushed
the
compliance-test-and-annotations
branch
from
8d3b6c4 to
a9270a4
Compare
brettmc
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.