Support async php runtimes #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #675 +/- ##
============================================
- Coverage 86.07% 84.77% -1.31%
- Complexity 1151 1213 +62
============================================
Files 128 136 +8
Lines 2794 2936 +142
============================================
+ Hits 2405 2489 +84
- Misses 389 447 +58
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Implementation currently incompatible with fibers.
Adds tests for newly added features and fixes covers annotations.
Nevay
force-pushed
the
feature/context-storage
branch
from
e13c0d8 to
53fc3a1
Compare
brettmc
reviewed
May 16, 2022
brettmc
reviewed
May 16, 2022
- move Swoole context storage to Contrib/Context/Swoole - use self instead of classname
brettmc
approved these changes
May 19, 2022
Closed
bobstrecansky
approved these changes
May 24, 2022
|
Came across this yesterday, and it looks really interesting for my @reactphp apps. But how do I use this? Is there any documentation or examples how to integrate this with an event loop, or an existing fibers implementation for awaiting promises? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for async userland implementations (resolves #671, replaces #674):
ScopeBoundCallables to preserve the original scope.ScopeBoundPromise. (Instrumentation returning promises should not::detach()the scope as promises are chained and not nested.)Additionally includes an experimental context storage to support execute_data switches performed by Swoole, should be moved out of src/Context into a contrib package or similar in the future.
Other changes: