-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Laravel and Symfony quickstarts #696
Updated Laravel and Symfony quickstarts #696
Conversation
Codecov Report
@@ Coverage Diff @@
## main #696 +/- ##
=========================================
Coverage 82.77% 82.77%
Complexity 1242 1242
=========================================
Files 139 139
Lines 3036 3036
=========================================
Hits 2513 2513
Misses 523 523
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still patching the front controller and using global states (which is the opposite of best practices)
@tidal For HelloController in both Laravel and Symfony, we have used |
As discussed in the SIG meeting today, incorporated changes from PR by DrLuke into this PR. |
Updated laravel and symfony quickstarts to create sample application with OTel PHP SDK integrated.
Closes #678
Closes #679