OtlpGrpc exporter for metrics #721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemkose
requested review from
bobstrecansky,
zsistla,
tidal and
brettmc
as code owners
|
It looks like I need to solve API on SDK issue first. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closing this PR since it was already implemented in #750 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #700
A new exporter for metrics using OTLP format. It is basically a copy of the existing
OpenTelemetry\Contrib\OtlpGrpc\Exporterexporter for traces. OTLP conversion is borrowed fromOpenTelemetry\Contrib\Otlp\SpanConverter.I also tried to update the metric related classes to use
ResourceInfoandInstrumentationScopeas it was defined in the documentation. I am not 100% sure if I understood/followed them correctly.