Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export otlp InstrumentationScope attributes #825

Merged
merged 2 commits into from
Sep 15, 2022
Merged

export otlp InstrumentationScope attributes #825

merged 2 commits into from
Sep 15, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Sep 14, 2022

Send InstrumentationScope attributes and dropped attributes count.

Closes #738

@brettmc brettmc requested a review from a team September 14, 2022 05:25
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #825 (1dcbadc) into main (ad3ccd8) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #825      +/-   ##
============================================
- Coverage     82.82%   82.59%   -0.24%     
- Complexity     1829     1884      +55     
============================================
  Files           223      230       +7     
  Lines          4723     4900     +177     
============================================
+ Hits           3912     4047     +135     
- Misses          811      853      +42     
Flag Coverage Δ
7.4 82.60% <100.00%> (-0.24%) ⬇️
8.0 82.62% <100.00%> (-0.24%) ⬇️
8.1 82.62% <100.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Contrib/Otlp/MetricConverter.php 100.00% <100.00%> (ø)
src/Contrib/Otlp/SpanConverter.php 98.96% <100.00%> (+0.01%) ⬆️
src/Contrib/OtlpHttp/Exporter.php 83.67% <0.00%> (-10.33%) ⬇️
src/Contrib/ZipkinToNewrelic/Exporter.php 95.83% <0.00%> (-0.84%) ⬇️
src/Contrib/OtlpGrpc/Exporter.php 91.17% <0.00%> (-0.26%) ⬇️
src/Contrib/Newrelic/Exporter.php 96.66% <0.00%> (-0.21%) ⬇️
src/API/Baggage/Baggage.php 83.87% <0.00%> (ø)
src/API/Trace/AbstractSpan.php 0.00% <0.00%> (ø)
src/Contrib/Zipkin/Exporter.php 100.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3ccd8...1dcbadc. Read the comment docs.

src/Contrib/Otlp/MetricConverter.php Outdated Show resolved Hide resolved
src/Contrib/Otlp/SpanConverter.php Outdated Show resolved Hide resolved
@bobstrecansky bobstrecansky merged commit b551294 into open-telemetry:main Sep 15, 2022
@brettmc brettmc deleted the instrumentation-scope-attributes branch October 25, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use in InstrumentationScope Attribues in OTLP Exporters once respective proto files are released.
3 participants