Transport - move contentType from ::send() argument to transport property
#831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move content type from `::send()` to transport property - move otlp exporter to `Otlp\` namespace
Nevay
commented
Sep 24, 2022
| @@ -20,8 +20,16 @@ | |||
|
|
|||
| final class GrpcTransportFactory implements TransportFactoryInterface | |||
| { | |||
| /** | |||
| * @psalm-param "application/x-protobuf" $contentType | |||
There was a problem hiding this comment.
Didn't find a solution that works with template type on TransportFactoryInterface.
| @@ -12,16 +12,14 @@ | |||
| */ | |||
| interface SpanExporterInterface | |||
| { | |||
| public static function fromConnectionString(string $endpointUrl, string $name, string $args); | |||
There was a problem hiding this comment.
Should use a SpanExporterFactoryInterface instead to allow injecting dependencies.
There was a problem hiding this comment.
Seems like a reasonable thing to do.
Nevay
changed the title
contentType from ::send() argument to transport property
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #831 +/- ##
============================================
- Coverage 82.54% 81.50% -1.05%
- Complexity 1877 1894 +17
============================================
Files 232 234 +2
Lines 4893 4919 +26
============================================
- Hits 4039 4009 -30
- Misses 854 910 +56
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brettmc
approved these changes
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move content type from
::send()argument to property.Also adds OTLP exporters that support protobuf and json format, based on the
::contentType()of the provided transport.