Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build arm64 base images #960

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

cedricziel
Copy link
Contributor

What

This adjusts the docker action to build a compatible arm64 image.

Why

I want to use the make scripts with my mac :)

@cedricziel cedricziel requested a review from a team April 5, 2023 18:49
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #960 (fd37e80) into main (502df0e) will not change coverage.
The diff coverage is n/a.

❗ Current head fd37e80 differs from pull request most recent head edbddc2. Consider uploading reports for the commit edbddc2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #960   +/-   ##
=========================================
  Coverage     83.34%   83.34%           
  Complexity     2126     2126           
=========================================
  Files           277      277           
  Lines          6105     6105           
=========================================
  Hits           5088     5088           
  Misses         1017     1017           
Flag Coverage Δ
7.4 81.98% <ø> (ø)
8.0 83.29% <ø> (ø)
8.1 83.42% <ø> (ø)
8.2 83.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502df0e...edbddc2. Read the comment docs.

@bobstrecansky bobstrecansky merged commit 72e9f56 into open-telemetry:main Apr 5, 2023
cedricziel added a commit to cedricziel/opentelemetry-php that referenced this pull request Apr 5, 2023
Use correct arm64 platform for building docker images.

My previous PR in open-telemetry#960 used the wrong platform for M1/Apple silicon
@cedricziel cedricziel deleted the arm64 branch April 5, 2023 19:18
bobstrecansky pushed a commit that referenced this pull request Apr 5, 2023
Use correct arm64 platform for building docker images.

My previous PR in #960 used the wrong platform for M1/Apple silicon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants