Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Makefile with executable permissions #540

Closed
marcalff opened this issue Apr 2, 2024 · 2 comments · Fixed by #541
Closed

File Makefile with executable permissions #540

marcalff opened this issue Apr 2, 2024 · 2 comments · Fixed by #541

Comments

@marcalff
Copy link
Member

marcalff commented Apr 2, 2024

The file Makefile has execute permissions in the github repository.

Is this intended ?

https://github.com/open-telemetry/opentelemetry-proto/blob/main/Makefile
This was referenced Apr 2, 2024
Merged
Open
@carlosalberto
Copy link
Contributor

Sounds it was not done on purpose, yes. @bogdandrutu @tigrannajaryan maybe you remember?

arminru added a commit to dynatrace-oss-contrib/opentelemetry-proto that referenced this issue Apr 2, 2024
@arminru
Unset executable flag on Makefile
45c398d 
Fixes open-telemetry#540.
@arminru arminru mentioned this issue Apr 2, 2024
Merged
@tigrannajaryan
Copy link
Member

Yes, likely accidental. No reason for it to be executable.

carlosalberto pushed a commit that referenced this issue Apr 2, 2024
@arminru
Unset executable flag on Makefile (#541)
84b3017 
Fixes #540.
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this issue Jun 21, 2024
@arminru @VinozzZ
Unset executable flag on Makefile (open-telemetry#541)
09ae9e6 
Fixes open-telemetry#540.
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this issue Jun 21, 2024
@arminru @VinozzZ
Unset executable flag on Makefile (open-telemetry#541)
f608843 
Fixes open-telemetry#540.
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this issue Jun 21, 2024
@arminru @VinozzZ
Unset executable flag on Makefile (open-telemetry#541)
20fda65 
Fixes open-telemetry#540.
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this issue Jun 21, 2024
@arminru @VinozzZ
Unset executable flag on Makefile (open-telemetry#541)
f7e458f 
Fixes open-telemetry#540.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unset executable flag on Makefile dynatrace-oss-contrib/opentelemetry-proto
3 participants
@carlosalberto @tigrannajaryan @marcalff