Declare Trace, Resource and Common as Beta #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the maturity levels for individual parts of the protocol according to recently agreed project-wide definition of maturity levels. After merging this change we will declare Trace (Span), Resource and Common parts of the protocol as Beta, which means no more than once in 3 months changes are allowed after that. We need this declaration of maturity so that we can begin implementation of OTLP in the Collector. One known pending change that prevents us from declaring the components as Stable is open-telemetry#94 We assume that there will be no other changes within the next 3-months timeframe. The assumption seems reasonable since there are no other known shortcomings in this part of the protocol that may require more modifications. Note that metrics part is considered Alpha since it is still under active development.
tigrannajaryan
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
|
@open-telemetry/specs-approvers please review. This blocks Collector progress. |
yurishkuro
approved these changes
Feb 13, 2020
|
@open-telemetry/specs-approvers please have a look and if you are OK with the proposal to declare parts of the protocol "Beta" please approve. Please do note that it means we do not expect major or frequent changes to data model of traces and spans in the API/SDK anymore. |
SergeyKanzhelev
approved these changes
Feb 17, 2020
| trace/trace_config.proto | Alpha | | ||
|
|
||
| (See [maturity-matrix.yaml](https://github.com/open-telemetry/community/blob/47813530864b9fe5a5146f466a58bd2bb94edc72/maturity-matrix.yaml#L57) |
There was a problem hiding this comment.
should this be described in a yaml file though?
There was a problem hiding this comment.
I wanted this to be visible and easily readable. Happy to update the yaml file in the community repo too, which currently does not currently have an entry for the protocol (I can add).
tedsuo
approved these changes
Feb 18, 2020
bogdandrutu
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the maturity levels for individual parts of the protocol
according to recently agreed project-wide definition of maturity levels.
After merging this change we will declare Trace (Span), Resource and
Common parts of the protocol as Beta, which means no more than once in
3 months changes are allowed after that.
We need this declaration of maturity so that we can begin implementation
of OTLP in the Collector.
One known pending change that prevents us from declaring the components
as Stable is #94
We assume that there will be no other changes within the next 3-months timeframe.
The assumption seems reasonable since there are no other known shortcomings
in this part of the protocol that may require more modifications.
Note that metrics part is considered Alpha since it is still under active
development.