-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TraceState to the LogRecord #522
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
e499018
to
b2739c2
Compare
Co-authored-by: Reiley Yang <reyang@microsoft.com>
I am struggling to understand what is the meaning and purpose of the tracestate in a LogRecord. Can someone explain? What do the receivers of such LogRecord supposed to do with this data? |
These are same reasons as why we propagate probability sampler here; TL;DR is that if you derive any metrics from these logs/events you can have a "weight" associated with that. |
Please add a description to this PR and refer to issues where this was discussed. I believe we had decided not to do this. Sampling SIG has discussed creating semantic conventions for encoding information we might usefully extract from tracestate to apply to log records, e.g., |
I don't have an issue, but if you have any prior discussion would be good to link as reference.
Would this scale for everything we like to put in tracestate (since I believe we may add more things into the tracestate)? What about other's tracestate (e.g. snwoflake's entry)? |
No description provided.