split sync and async tests (fix review)

open-telemetry · Sep 17, 2024 · 0e8f8d1 · 0e8f8d1
1 parent ebca082
commit 0e8f8d1
Showing 1 changed file with 23 additions and 21 deletions.
diff --git a/instrumentation/opentelemetry-instrumentation-aiokafka/tests/test_instrumentation.py b/instrumentation/opentelemetry-instrumentation-aiokafka/tests/test_instrumentation.py
@@ -14,7 +14,7 @@
 
 import uuid
 from typing import Any, List, Sequence, Tuple
-from unittest import IsolatedAsyncioTestCase, mock
+from unittest import IsolatedAsyncioTestCase, TestCase, mock
 
 from aiokafka import (
     AIOKafkaConsumer,
@@ -33,7 +33,28 @@
 from opentelemetry.trace import SpanKind, format_trace_id, set_span_in_context
 
 
-class TestAIOKafka(TestBase, IsolatedAsyncioTestCase):
+class TestAIOKafkaInstrumentor(TestCase):
+    def test_instrument_api(self) -> None:
+        instrumentation = AIOKafkaInstrumentor()
+
+        instrumentation.instrument()
+        self.assertTrue(
+            isinstance(AIOKafkaProducer.send, BoundFunctionWrapper)
+        )
+        self.assertTrue(
+            isinstance(AIOKafkaConsumer.getone, BoundFunctionWrapper)
+        )
+
+        instrumentation.uninstrument()
+        self.assertFalse(
+            isinstance(AIOKafkaProducer.send, BoundFunctionWrapper)
+        )
+        self.assertFalse(
+            isinstance(AIOKafkaConsumer.getone, BoundFunctionWrapper)
+        )
+
+
+class TestAIOKafkaInstrumentation(TestBase, IsolatedAsyncioTestCase):
     @staticmethod
     def consumer_record_factory(
         number: int, headers: Tuple[Tuple[str, bytes], ...]
@@ -79,25 +100,6 @@ async def producer_factory() -> AIOKafkaProducer:
 
         return producer
 
-    def test_instrument_api(self) -> None:
-        instrumentation = AIOKafkaInstrumentor()
-
-        instrumentation.instrument()
-        self.assertTrue(
-            isinstance(AIOKafkaProducer.send, BoundFunctionWrapper)
-        )
-        self.assertTrue(
-            isinstance(AIOKafkaConsumer.getone, BoundFunctionWrapper)
-        )
-
-        instrumentation.uninstrument()
-        self.assertFalse(
-            isinstance(AIOKafkaProducer.send, BoundFunctionWrapper)
-        )
-        self.assertFalse(
-            isinstance(AIOKafkaConsumer.getone, BoundFunctionWrapper)
-        )
-
     async def test_getone(self) -> None:
         AIOKafkaInstrumentor().uninstrument()
         AIOKafkaInstrumentor().instrument(tracer_provider=self.tracer_provider)