Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[instrumentation-system-metrics] Remove labels configuration #1034

Open
codeboten opened this issue Apr 6, 2022 · 2 comments · May be fixed by #1570
Open

[instrumentation-system-metrics] Remove labels configuration #1034

codeboten opened this issue Apr 6, 2022 · 2 comments · May be fixed by #1570
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed instrumentation metrics

Comments

@codeboten
Copy link
Contributor

As per Aaron's comment, the labels configuration parameter is no longer needed as views offer the same functionality.

It looks like this just adds extra attributes to all measurements. We should probably remove this?

We can do it in a separate PR though as this is just restoring the package

Originally posted by @aabmass in #1012 (comment)

@pridhi-arora
Copy link
Contributor

@srikanthccv Can I take this up?

@srikanthccv
Copy link
Member

Let me know if you need help understanding the issue if it's not already clear.

@pridhi-arora pridhi-arora linked a pull request Jan 8, 2023 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed instrumentation metrics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants