opentelemetry-instrumentation-system-metrics restore package
#1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 4, 2022 11:07
Restore the system-metrics instrumentation package into main from the `metrics` branch and update its usage of the api/sdk. Fix open-telemetry#1011
codeboten
force-pushed
the
codeboten/restore-system-metrics
branch
from
f751396 to
f105899
Compare
aabmass
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
I think the configuration mechanism in this instrumentation is largely superseded by views. Wdyt @codeboten?
Approving since most of this code is being restored. Thanks for undertaking this Alex!
...-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
Show resolved
Hide resolved
...-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-system-metrics/tests/test_system_metrics.py
Outdated
Show resolved
Hide resolved
added 3 commits
April 5, 2022 15:15
srikanthccv
reviewed
Apr 6, 2022
instrumentation/opentelemetry-instrumentation-system-metrics/setup.cfg
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-system-metrics/setup.cfg
Outdated
Show resolved
Hide resolved
This was referenced Apr 6, 2022
lzchen
reviewed
Apr 6, 2022
srikanthccv
approved these changes
Apr 6, 2022
lzchen
reviewed
Apr 6, 2022
...-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Apr 6, 2022
...-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Apr 6, 2022
...-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
Show resolved
Hide resolved
lzchen
reviewed
Apr 6, 2022
...-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
Apr 6, 2022
added 2 commits
April 6, 2022 10:25
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restore the system-metrics instrumentation package into main from the
metricsbranch and update its usage of the api/sdk. Leaving in draft until the tests are fixedFix #1011
Type of change
Please delete options that are not relevant.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.