Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Pika 0.28b0 instrumentation requires packaging, not declared in transitive dependencies #881

Closed
phillipuniverse opened this issue Jan 27, 2022 · 1 comment · Fixed by #882
Labels
bug Something isn't working

Comments

@phillipuniverse
Copy link
Contributor

Describe your environment

I just upgraded opentelemetry-instrumentation-pika in my environment to 0.28b0. The commit at 26aa17f and #837 introduced this line:

from packaging import version

This results in the following in my environment:

ModuleNotFoundError: No module named 'packaging'

I assume the problem is that I don't have any of the setuptools or related dependencies in my environment since I'm deploying a webapp on Docker. But I would have expected at least a new transitive dependency or something in order to use this functionality.

My environment is Python 3.7.12 and I am using the Docker image FROM python:3.7.12-buster.

This fortunately doesn't break my whole environment, but I do get the ModuleNotFoundError: Instrumenting of pika failed message.

@phillipuniverse phillipuniverse added the bug Something isn't working label Jan 27, 2022
phillipuniverse added a commit to phillipuniverse/opentelemetry-python-contrib that referenced this issue Jan 28, 2022
@phillipuniverse
Copy link
Contributor Author

The fix is to add packaging into your venv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant