Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in latest from datadog/dd-trace-py #1

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

brettlangdon
Copy link
Contributor

@codeboten
Copy link
Contributor

codeboten commented Feb 6, 2020

Thanks for this! Looks like the CLA check is still failing,@brettlangdon can you confirm you've signed it?

@Oberon00
Copy link
Member

Oberon00 commented Feb 7, 2020

For a PR to pass, each commit must pass this check: the Github user that the commit is attributed to (based on a match between the commit authorship and Github profile) must be linked to a Linux Foundation ID user [...]

-- https://identity.linuxfoundation.org/projects/cncf

I assume, since this PR contains commits by many users, all of them need to sign the CLA.

@brettlangdon
Copy link
Contributor Author

I signed the CLA

@tedsuo
Copy link

tedsuo commented Feb 20, 2020

Hi @brettlangdon. After some debate in the Python SIG, we've decided to take a slightly different approach. We're still very interested in this donation - especially the instrumentation. But, rather than start from one repo and modify the pieces in-place to match OpenTelemetry, we would like the PRs to have already modified the individual pieces. This will allow us to take donations from multiple sources, and avoid having to track down the other 20+ individuals who would also need so sign the CLA as part of this donation.

We'd like our auto-instrumentation story broken into two parts. The first part is the auto-installer, containing the core components for installing the SDK, plugins, and instrumentation packages.

The second part is each individual plugin and instrumentation package. Most of them will likely live in a python-contrib package for now, and the rest in 3rd-party repos.

The technical details of the approach we would like to take can be found here. It is very similar to Datadog's approach, with some additional details. We would appreciate a review of this document, if you have the time: https://gist.github.com/ocelotl/bf7bfcbb407b995280b6ef48c3870015

Apologies for the change of plans after you already made the PR - the surprise CLA requirement was kind of a doozy. Again, we really appreciate this work being provided from Datadog. We're hoping that an expert in python auto-instrumentation (possibly you?) would still be available to advise and assist us with building auto-installation for OpenTelemetry.

Please let me know if you have any questions. Once this PR is resolved, we will delete this repo and begin porting components to the main https://github.com/open-telemetry/opentelemetry-python repo.

Thank you,
@tedsuo

@tedsuo
Copy link

tedsuo commented Feb 26, 2020

Glad to see the CLA issues resolved. @codeboten this LGTM.

@codeboten codeboten merged commit f13c716 into open-telemetry:master Feb 26, 2020
brianwarner pushed a commit to fidelity-contributions/open-telemetry-opentelemetry-python-contrib that referenced this pull request May 2, 2024
injection when passing user input as keys to xmlattr filter open-telemetry#1
znd4 pushed a commit to znd4/opentelemetry-python-contrib that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants