-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uninstruemnt existing instances before uninstrumenting fastapi class #1258
uninstruemnt existing instances before uninstrumenting fastapi class #1258
Conversation
…ul756/opentelemetry-python-contrib into fix-uninstrument-fastapi
…python-contrib into fix-uninstrument-fastapi
…python-contrib into fix-uninstrument-fastapi
…ul756/opentelemetry-python-contrib into fix-uninstrument-fastapi
.../opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py
Outdated
Show resolved
Hide resolved
…python-contrib into fix-uninstrument-fastapi
…ul756/opentelemetry-python-contrib into fix-uninstrument-fastapi
When was this discussed? As a user this makes sense to me but we'll have to do this for other instrumentations as well. Could we make tracking issues for those? |
This was briefly discussed in one of the SIG meetings when the topic was brought up by I believe Sanket. Some instrumentations haven't been fixed for this case but generally, we are trying to ensure the |
Resolve the generate test issue |
Description
Create a static list of all instances of InstrumentedFastAPI and fix uninstrument function.
Fixes #1256
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e test-instrumentation-fastapi
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.