-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pymongo capture collection name #1555
Merged
srikanthccv
merged 14 commits into
open-telemetry:main
from
avzis:pymongo_capture_collection
Jan 11, 2023
Merged
Pymongo capture collection name #1555
srikanthccv
merged 14 commits into
open-telemetry:main
from
avzis:pymongo_capture_collection
Jan 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalevr
reviewed
Jan 3, 2023
.../opentelemetry-instrumentation-pymongo/src/opentelemetry/instrumentation/pymongo/__init__.py
Show resolved
Hide resolved
srikanthccv
approved these changes
Jan 3, 2023
srikanthccv
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specs -
mongodb should capture: "The collection being accessed within the database stated in db.name."
and save it in:
db.mongodb.collection
Fixes #1539
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added validation to the tests to verify that the property
db.mongodb.collection
is captured correctlyDoes This PR Require a Core Repo Change?