Skip to content

Audit and test opentelemetry-instrumentation-wsgi NoOpTracerProvider #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 13, 2023
Merged

Audit and test opentelemetry-instrumentation-wsgi NoOpTracerProvider #1610

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4c300bd
Audit and test opentelemetry-instrumentation-wsgi NoOpTracerProvider
Akochavi Jan 30, 2023
ba46247
Fix cr
Akochavi Jan 30, 2023
710e413
wip
Akochavi Feb 8, 2023
a766a1d
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation…
srikanthccv Feb 10, 2023
8f893bc
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation…
shalevr Feb 13, 2023
62266ac
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation…
srikanthccv Feb 13, 2023
5525a4b
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation…
shalevr Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions instrumentation/opentelemetry-instrumentation-wsgi/tests/test_wsgi_middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,16 @@ def test_basic_wsgi_call(self):
response = app(self.environ, self.start_response)
self.validate_response(response, exporter)

def test_no_op_tracer_provider(self):
app = otel_wsgi.OpenTelemetryMiddleware(
simple_wsgi, tracer_provider=trace_api.NoOpTracerProvider
Copy link
Member

@shalevr shalevr Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use trace_api.NoOpTracerProvider()
You should move to the instrument function initialized tracer_provider and not the Class object

Copy link
Contributor Author

@Akochavi Akochavi Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

)

response = app(self.environ, self.start_response)
next(response)
Copy link
Member

@shalevr shalevr Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next(response) will throw a StopIteration exception if the iterator is empty

span_list = self.memory_exporter.get_finished_spans()
self.assertEqual(len(span_list), 0)


class TestWsgiMiddlewareWrappedWithAnotherFramework(WsgiTestBase):
def test_mark_span_internal_in_presence_of_span_from_other_framework(self):
Expand Down