Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added request and response hooks for grpc client #1706

Merged

Conversation

prsnca
Copy link
Contributor

@prsnca prsnca commented Mar 2, 2023

Description

Added an option to configure request and response hooks for GRPC clients.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A added request and response hooks which add span attributes
  • Test B added faulty request and response hooks and verified they do not break the instrumentation nor the application.

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@prsnca prsnca requested a review from a team March 2, 2023 09:39
@prsnca prsnca force-pushed the add-response-and-request-hooks branch from 174c1bb to b2a45a3 Compare March 2, 2023 09:44
@prsnca prsnca force-pushed the add-response-and-request-hooks branch from b2a45a3 to 3432bad Compare March 23, 2023 17:03
@shalevr
Copy link
Member

shalevr commented Apr 4, 2023

Please update your branch

@nozik
Copy link
Contributor

nozik commented Apr 4, 2023

@shalevr Done

CHANGELOG.md Outdated Show resolved Hide resolved
@srikanthccv srikanthccv merged commit d01c96f into open-telemetry:main Apr 15, 2023
@nozik nozik deleted the add-response-and-request-hooks branch April 17, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants