Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus Remote Write Exporter (2/6) #206

Merged

Conversation

AzfaarQureshi
Copy link
Contributor

@AzfaarQureshi AzfaarQureshi commented Nov 23, 2020

Description

This is PR 2/6 of adding a Prometheus Remote Write Exporter in Python SDK and address Issue open-telemetry/opentelemetry-python#1302

Part 1/6

  • Adds class skeleton
  • Adds all function signatures

👉 Part 2/6

  • Adds validation of exporter constructor commands
  • Add unit tests for validation

Part 3/6

  • Adds conversion methods from OTel metric types to Prometheus TimeSeries
  • Add unit tests for conversion

Part 4/6

  • Adds methods to export metrics to Remote Write endpoint
  • Add unit tests for exporting

Part 5/6

  • Add integration tests using sample app and instance of Cortex

Part 6/6

  • Add README, Design Doc and other necessary documentation.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Added class TestValidation in test_prometheus_remote_write_exporter.py

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated
    cc- @shovnik, @alolita

@AzfaarQureshi AzfaarQureshi requested review from a team, codeboten and lzchen and removed request for a team November 23, 2020 23:24
@AzfaarQureshi AzfaarQureshi force-pushed the 1-prometheus-remote-write branch 4 times, most recently from 45f6069 to 4b0b438 Compare November 24, 2020 19:56
@AzfaarQureshi AzfaarQureshi changed the title Prometheus Remote Write Exporter (2/7) Prometheus Remote Write Exporter (2/6) Nov 24, 2020
@AzfaarQureshi AzfaarQureshi force-pushed the 1-prometheus-remote-write branch from 4b0b438 to 19d2b87 Compare November 24, 2020 20:45
@AzfaarQureshi AzfaarQureshi force-pushed the 1-prometheus-remote-write branch 2 times, most recently from 429393b to 249ed32 Compare November 24, 2020 21:44
@AzfaarQureshi AzfaarQureshi changed the title Prometheus Remote Write Exporter (2/6) Add Prometheus Remote Write Exporter (2/6) Nov 24, 2020
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested, not enough to not approve this PR 👍

@AzfaarQureshi AzfaarQureshi force-pushed the 1-prometheus-remote-write branch 2 times, most recently from 2688201 to cf31639 Compare November 26, 2020 18:05
@AzfaarQureshi AzfaarQureshi force-pushed the 1-prometheus-remote-write branch 3 times, most recently from 418977a to e0a6489 Compare November 27, 2020 18:03
fix lint changes
@AzfaarQureshi AzfaarQureshi force-pushed the 1-prometheus-remote-write branch from e0a6489 to a47a89e Compare November 27, 2020 18:04
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants