Fixing w3c baggage support in opentelemetry-instrumentation-aws-lambda #2589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing baggage support in
opentelemetry-instrumentation-aws-lambda
package.After determining the parent context (
_determine_parent_context()
), it was only used to create the wrapper span, but wasn't attached to the global context. Although thestart_as_current_span()
call attaches the span's context, but because theSpanContext
only contains span-related info, the baggage content was lost, and the propagators couldn't pick it up.This change attaches/detaches the baggage to the context in a
try/finally
clause. Other instrumentations do the same either directly, or through_start_internal_or_server_span()
.Type of change
How Has This Been Tested?
Implemented a unit test, and ran all the relevant tests:
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.