Sort labelset to ensure compatibility with thanos-receive #2784
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fstolba You need to sign the CLA in order to have your changes integrated |
|
Hello guys, i also faced this issue and confirm that the commit proposed by @fstolba fixes this timeseries error !
|
|
Sorry for the delay, CLA is now signed. |
emdneto
reviewed
Sep 16, 2024
There was a problem hiding this comment.
I think this can happen not only for Thanos but also for every Prometheus-like backend. Maybe it's worth having a comment and a simple test to prevent someone from removing that. prometheus/prometheus#11505
Could you please add changelog and fix lint?
|
@fstolba Have you looked into adding a test (or an assert to an existing one) to checj that the labels are sorted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using thanos-receive which requires labels to be sorted lexicographically. Trying to submit a metric without first sorting the label list results in the write request being rejected, yielding the message
Out of order labels in the label set.This PR fixes this behaviour.
Please note I only tested this on thanos-remote, could use testing on other implementations.