-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VertexAI emit user, system, and assistant events #3203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned alizenhom, codefromthecrypt, gyliu513, karthikscale3, lmolkova, lzchen and nirga
Jan 23, 2025
github-actions
bot
requested review from
alizenhom,
codefromthecrypt,
gyliu513,
karthikscale3,
lmolkova,
lzchen and
nirga
January 23, 2025 05:20
aabmass
force-pushed
the
vertex-1-events
branch
2 times, most recently
from
January 23, 2025 06:17
208af92
to
5033da7
Compare
aabmass
changed the title
VertexAI emit user events
VertexAI emit user, system, and assistant events
Jan 23, 2025
aabmass
force-pushed
the
vertex-1-events
branch
from
January 23, 2025 21:09
aedc6f4
to
1760c68
Compare
xrmx
reviewed
Jan 24, 2025
...i/opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/patch.py
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Jan 28, 2025
...i/opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/utils.py
Show resolved
Hide resolved
emdneto
approved these changes
Jan 29, 2025
.../opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/events.py
Outdated
Show resolved
Hide resolved
.../opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/events.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
aryabharat
pushed a commit
to aryabharat/opentelemetry-python-contrib
that referenced
this pull request
Feb 2, 2025
* VertexAI emit user events * Emit system and assistant events * Fix for python 3.8 * Record events regardless of span recording * fix tests * Apply suggestions from code review Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com> --------- Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #3041, follow up to #3192
Adds Gen AI events for model input to the VertexAI instrumentation. These are system event, user event, and assistant event.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added test cases for the various log events with
OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT
varied true and false.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.