Update vertexai instrumentation to be in-line with the latest semantic conventions part 2 #3799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SGTM the hook should also not stamp a reference in this case I think. |
aabmass
approved these changes
Oct 1, 2025
instrumentation-genai/opentelemetry-instrumentation-vertexai/examples/manual/.env
Outdated
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-vertexai/examples/zero-code/.env
Outdated
Show resolved
Hide resolved
...i/opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/patch.py
Outdated
Show resolved
Hide resolved
...i/opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/patch.py
Outdated
Show resolved
Hide resolved
...i/opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/patch.py
Outdated
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-vertexai/tests/conftest.py
Outdated
Show resolved
Hide resolved
...i/opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/patch.py
Outdated
Show resolved
Hide resolved
5 tasks
Contributor
Author
|
I can't get docs to pass. "reference target not found: json.encoder.JSONEncoder" --> not sure how to resolve that. |
…ython-contrib into vertexai_v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #3709. Finish updating the vertex ai instrumentation to use the semantic convention changes made in open-telemetry/semantic-conventions#2179.
Updates the instrumentation to call the completion hook as well. I think we need to update the completion hook to not upload anything when an empty list is passed to it. Right now it uploads empty list of system instructions / inputs / outputs if that's what's passed to it.
Type of change
How Has This Been Tested?
Unit tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.