Support passing tracer provider in aiohttp server instrumentation lib #3819

bisgaard-itis · 2025-10-08T10:44:32Z

Description

Support passing a TracerProvider when using the aiohttp server instrumentation library. This gives users of the library the possibility to provide their own TracerProvider instead of relying on the global one. This is in particular useful for testing.

Fixes # (issue)

resolves Allow passing a TracerProvider when instrumenting an aiohttp server #3801

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

I added the test test_non_global_tracer_provider which checks that a non-global TracerProvider can be provided when instrumenting the aiohttp server. I check that the non-global TracerProvider is used by the instrumentation library by setting a non-default sampling probability in that provider and checking that the corresponding number of traces are collected.

Does This PR Require a Core Repo Change?

Yes. - Link to PR:
No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

Followed the style guidelines of this project
Changelogs have been updated
Unit tests have been added
Documentation has been updated

linux-foundation-easycla · 2025-10-08T10:44:38Z

The committers listed above are authorized under a signed CLA.

✅ login: bisgaard-itis / name: Mads Bisgaard (9460dde, c0d6ec7)

xrmx · 2025-10-10T08:17:57Z

@bisgaard-itis You need to sign the CLA in order to contribute to OpenTelemetry, thanks.

bisgaard-itis · 2025-10-17T11:55:23Z

@bisgaard-itis You need to sign the CLA in order to contribute to OpenTelemetry, thanks.

Perfect, thanks a lot for pointing this out @xrmx. I have signed it.

bisgaard-itis · 2025-10-26T21:35:33Z

@krnr this PR has been hanging for some time. Can I convince you to to review it? 🙏🏻

krnr · 2025-10-27T13:39:27Z

@krnr this PR has been hanging for some time. Can I convince you to to review it? 🙏🏻

i see no issues, the code is pretty much straight-forward - the same middleware logic, but the middleware itself is created on-the-fly. i like it 👍

...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py

CHANGELOG.md

tammy-baylis-swi · 2025-10-28T21:53:05Z

Also:

precommit is failing; please run tox -e ruff on your local and commit changes.
Some aiohttp-server tests are failing, please take a look.

…lemetry#3875) * Only decode JSON input buffer in Anthropic Claude streaming _decode_tool_use was only used when _tool_json_input_buf was found, but we were decoding the entire _content_block after adding _tool_json_input_buf to it. The _content_block overall which could contain non-JSON elements (e.g. {}), causing failures. To fix this, we have removed _decode_tool_use helper function and inlined JSON decoding logic directly into content_block_stop handler in _process_anthropic_claude_chunk, where we only use it to decode _tool_json_input_buf before appending to _content_block. * Update test_botocore_bedrock.py Fix lint: `opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py:2990:4: C0415: Import outside toplevel (opentelemetry.instrumentation.botocore.extensions.bedrock_utils.InvokeModelWithResponseStreamWrapper) (import-outside-toplevel)` * Update test_botocore_bedrock.py Remove extra line * fix lint issue

* Stop using deprecated span.instrumentation_info * aiohttp-client: add support for OTEL_PYTHON_EXCLUDED_URLS / OTEL_PYTHON_HTTPX_EXCLUDED_URLS * Add docs * Add changelog * Please lint * Update CHANGELOG.md Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com> * Test for both env vars * Assert at each iteration --------- Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com>

bisgaard-itis · 2025-11-03T08:56:11Z

Thanks a lot for the review @tammy-baylis-swi 🙏🏻. I have done the changes you requested.

…acerProvider-in-aiohttp-server-instrumentation-lib

tammy-baylis-swi · 2025-11-03T18:47:58Z

...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py

+    from opentelemetry.sdk.trace.sampling import ParentBased, TraceIdRatioBased

-    AioHttpServerInstrumentor().instrument()
+    resource = Resource(attributes={"service.name": "my-aiohttp-service"})


Great! I would also add a comment so newer/quickstart users know that these are optional:

Suggested change

resource = Resource(attributes={"service.name": "my-aiohttp-service"})

# Optional: configure non-default TracerProvider, resource, sampler

resource = Resource(attributes={"service.name": "my-aiohttp-service"})

tammy-baylis-swi · 2025-11-03T18:51:23Z

For the current pypy test failure in CI/CD, a couple of the definitions like tracer_provider: trace.TracerProvider | None = None, will need to change to tracer_provider: Optional[trace.TracerProvider] = None,

The GenAI test fail is unrelated to the changes in this PR and will be patched by the maintainers.

bisgaard-itis changed the title ~~3801 support passing tracer provider in aiohttp server instrumentation lib~~ Support passing tracer provider in aiohttp server instrumentation lib Oct 8, 2025

bisgaard-itis mentioned this pull request Oct 8, 2025

🚨✨ Implement tracing sampling strategy (🚧 devops 🚧) ITISFoundation/osparc-simcore#8421

Merged

xrmx added this to @xrmx's Python PR digest Oct 10, 2025

xrmx moved this to Reviewed PRs that need fixes in @xrmx's Python PR digest Oct 10, 2025

bisgaard-itis requested a review from a team as a code owner October 26, 2025 21:34

tammy-baylis-swi reviewed Oct 28, 2025

View reviewed changes

...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py Show resolved Hide resolved

tammy-baylis-swi reviewed Oct 28, 2025

View reviewed changes

...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py Outdated Show resolved Hide resolved

tammy-baylis-swi reviewed Oct 28, 2025

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

github-actions bot assigned codefromthecrypt, DylanRussell, karthikscale3, lzchen and nirga Nov 3, 2025

bisgaard-itis and others added 11 commits November 3, 2025 09:39

allow to pass tracer_provider when instrumenting aiohttp server

a54fdd3

minor fix

8772240

add note to indicate backwards compatibility

8021f70

small fix

09c4164

add test

7d1be5f

update changelog

07f833f

update changelog

a7b4a88

@tammy-baylis-swi add link to PR

a89c17f

create factory for instrumented application

b679ee1

run precommit hooks

4a57b3e

bisgaard-itis force-pushed the 3801-support-passing-TracerProvider-in-aiohttp-server-instrumentation-lib branch from a5bada0 to 4a57b3e Compare November 3, 2025 08:42

bisgaard-itis added 2 commits November 3, 2025 09:51

update readthedocs

35cce28

cleanup changelog after merge conflicts

6ffc359

bisgaard-itis requested a review from tammy-baylis-swi November 3, 2025 08:55

bisgaard-itis added 2 commits November 3, 2025 13:24

Merge remote-tracking branch 'otel/main' into 3801-support-passing-Tr…

c0d6ec7

…acerProvider-in-aiohttp-server-instrumentation-lib

make pre-commit happy

9460dde

tammy-baylis-swi reviewed Nov 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support passing tracer provider in aiohttp server instrumentation lib #3819

Support passing tracer provider in aiohttp server instrumentation lib #3819

bisgaard-itis commented Oct 8, 2025 •

edited

Loading

Uh oh!

linux-foundation-easycla bot commented Oct 8, 2025 •

edited

Loading

Uh oh!

xrmx commented Oct 10, 2025

Uh oh!

bisgaard-itis commented Oct 17, 2025

Uh oh!

bisgaard-itis commented Oct 26, 2025

Uh oh!

krnr commented Oct 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tammy-baylis-swi commented Oct 28, 2025

Uh oh!

bisgaard-itis commented Nov 3, 2025

Uh oh!

tammy-baylis-swi Nov 3, 2025

Uh oh!

tammy-baylis-swi commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

	resource = Resource(attributes={"service.name": "my-aiohttp-service"})
	# Optional: configure non-default TracerProvider, resource, sampler
	resource = Resource(attributes={"service.name": "my-aiohttp-service"})

Support passing tracer provider in aiohttp server instrumentation lib #3819

Are you sure you want to change the base?

Support passing tracer provider in aiohttp server instrumentation lib #3819

Conversation

bisgaard-itis commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Does This PR Require a Core Repo Change?

Checklist:

Uh oh!

linux-foundation-easycla bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xrmx commented Oct 10, 2025

Uh oh!

bisgaard-itis commented Oct 17, 2025

Uh oh!

bisgaard-itis commented Oct 26, 2025

Uh oh!

krnr commented Oct 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tammy-baylis-swi commented Oct 28, 2025

Uh oh!

bisgaard-itis commented Nov 3, 2025

Uh oh!

tammy-baylis-swi Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

tammy-baylis-swi commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

bisgaard-itis commented Oct 8, 2025 •

edited

Loading

linux-foundation-easycla bot commented Oct 8, 2025 •

edited

Loading