Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use basename to get package name #583

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Use basename to get package name #583

merged 1 commit into from
Jul 14, 2021

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jul 14, 2021

Fixes #582

@ocelotl ocelotl added bug Something isn't working build & infra labels Jul 14, 2021
@ocelotl ocelotl requested review from codeboten and lzchen July 14, 2021 04:31
@ocelotl ocelotl self-assigned this Jul 14, 2021
@ocelotl ocelotl requested a review from a team July 14, 2021 04:31
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 14, 2021
codeboten
codeboten approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the same change be needed in the core repo?

@codeboten codeboten merged commit bf6fd08 into open-telemetry:main Jul 14, 2021
@ocelotl ocelotl deleted the issue_582 branch July 14, 2021 15:17
@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 14, 2021

Will the same change be needed in the core repo?

Thanks for pointing that out, it is not strictly necessary since the script in the core repo does not use maxsplit= but it would be an improvement, will open a PR. ✌️

@ocelotl ocelotl mentioned this pull request Jul 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@horsfallnathan horsfallnathan horsfallnathan approved these changes

@aabmass aabmass aabmass approved these changes

@codeboten codeboten codeboten approved these changes

@lzchen lzchen Awaiting requested review from lzchen

Assignees

@ocelotl ocelotl

Labels
bug Something isn't working build & infra Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix eachdist.py
5 participants
@ocelotl @codeboten @aabmass @horsfallnathan @srikanthccv