Respect provided tracer provider when instrumenting SQLAlchemy #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
reviewed
Oct 12, 2021
...ntelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py
Outdated
Show resolved
Hide resolved
|
@jfmyers9 thanks for fixing this. Please sign the CLA as described here: #728 (comment) |
|
@jfmyers9 thanks. please also add a changelog entry |
jfmyers9
force-pushed
the
respect-tracer-provider-sqlalchemy
branch
from
f55d582 to
bc02c59
Compare
owais
approved these changes
Oct 12, 2021
|
Working on getting the CLA signed. Will get back to you when I figure that out. |
This change updates the SQLALchemyInstrumentor to respect the tracer provider that is passed in through the kwargs when patching the `create_engine` functionality provided by SQLAlchemy. Previously, it would default to the global tracer provider.
auto-merge was automatically disabled
October 12, 2021 16:08
Head branch was pushed to by a user without write access
jfmyers9
force-pushed
the
respect-tracer-provider-sqlalchemy
branch
from
bc02c59 to
cd32211
Compare
auto-merge was automatically disabled
October 12, 2021 16:32
Head branch was pushed to by a user without write access
lzchen
approved these changes
Oct 12, 2021
|
@owais Is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change updates the SQLALchemyInstrumentor to respect the tracer provider that is passed in through the kwargs when patching the
create_enginefunctionality provided by SQLAlchemy. Previously, it would default to the global tracer provider.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tested and tested in a real environment.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.