Bugfix/set default headers for properties in pika #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
reviewed
Oct 15, 2021
| ctx = propagate.extract(properties.headers, getter=_pika_getter) | ||
| if not ctx: | ||
| ctx = context.get_current() | ||
| span = _get_span( | ||
| tracer, | ||
| channel, | ||
| properties, | ||
| span_kind=SpanKind.CLIENT, |
There was a problem hiding this comment.
shoudl this be producer/consumer instead of client/server?
There was a problem hiding this comment.
I guess you're right as pika does use callbacks. Updated.
There was a problem hiding this comment.
It is more about the communication being a single round-trip like HTTP vs async message queue one like RabbitMQ. I'm guessing pika enables the later type of communication, right?
There was a problem hiding this comment.
Yeah, You create a single connection and declare one or many channels, over which you declare one or many callbacks. So it is more of a producer/consumer than client/server.
owais
approved these changes
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pika instrumentation injects the context into the
properties.headersof the connection. If the properties are not provided, it generates a newBasicPropertiesobject, which by default sets headers toNoneinstead of an empty dict - which results in a failure to inject the context into the headers.The fix was to set the
headers={}by default when creating theBasicPropertiesobject.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
A pika client that creates a pika connection and executes
basic_publishwithout properties.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.