Add support instrumentation for Tornado 5.1.1 #812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now tornado-instrumentaion support only Tornado version more than 6.0, but in instrumentation code not anything specifics for Tornado 6 there are. There is release note for Tornado 6.0, and noone backwards-incompatible changes using in actual implementation of instumentation. I've tested Tornado instrumentation for last 5s version (5.1.1) in my highload project for this version and it works for me. Alternative way, using opentracing instead of opentelemetry, is not quite good, because a lot of part of microserfices may using opentelemetry for Java, Go and different languages. For more complecevity good reason for using opentelemetry for old tornado version.
Type of change
How Has This Been Tested?
Run current tests for Tornado 5.1.1 on Python 3.8.10. Start up on highload service (8000 rps) on pythonv 3.8.10. Check generated span and send throgh OTL. As a result - see span on Jaeger.
Does This PR Require a Core Repo Change?
Checklist: