Merge parallel benchmarks + include propagator + latest GH action #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
added
the
Skip Changelog
NathanielRN
changed the title
NathanielRN
force-pushed
the
include-propagator-benchmarks
branch
2 times, most recently
from
2f803e8 to
462e374
Compare
NathanielRN
changed the title
NathanielRN
force-pushed
the
include-propagator-benchmarks
branch
2 times, most recently
from
177ce13 to
c66ad04
Compare
owais
approved these changes
Dec 21, 2021
* When we moved the aws-xray propagator in open-telemetry#720, we needed to update the benchmark step of the workflow * Additionally, the GH action has evolved since we added benchmarks so we should use the latest version
NathanielRN
force-pushed
the
include-propagator-benchmarks
branch
from
c66ad04 to
e602ee2
Compare
NathanielRN
force-pushed
the
include-propagator-benchmarks
branch
from
e602ee2 to
0f873cb
Compare
srikanthccv
approved these changes
Dec 23, 2021
3 tasks
ItayGibel-helios
pushed a commit
to helios/opentelemetry-python-contrib
that referenced
this pull request
Dec 26, 2021
…en-telemetry#838) * Include propagator benchmarks + latest GH action * When we moved the aws-xray propagator in open-telemetry#720, we needed to update the benchmark step of the workflow * Additionally, the GH action has evolved since we added benchmarks so we should use the latest version * Merge all parallel benchmarks after they complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opentelemetry-propagators-awspackage #720, we needed to update the benchmark step of the workflowNOTE: Because the test run in parallel, there is a chance there is a race condition between the tests as they fight to lock theI decided to add the separate job in this PR, please let me know what you all think!gh-pagesbranch and publish the benchmarks. This will cause the test to fail. We should come up with a way to have all the jobs upload the benchmarks as artifacts and then combine them in a later job.Fixes: N/A
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The test worked before, this just includes them again now that they are in a new package.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
- [] Changelogs have been updated- [ ] Unit tests have been added- [ ] Documentation has been updated