addressing feedback

open-telemetry · Oct 28, 2019 · 16a95d5 · 16a95d5
1 parent ed628aa
commit 16a95d5
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/examples/trace/server.py b/examples/trace/server.py
@@ -14,8 +14,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import json
-
 import flask
 import requests
 

diff --git a/opentelemetry-api/src/opentelemetry/trace/__init__.py b/opentelemetry-api/src/opentelemetry/trace/__init__.py
@@ -62,7 +62,6 @@
 """
 
 import enum
-import random
 import types as python_types
 import typing
 from contextlib import contextmanager

diff --git a/opentelemetry-api/tests/context/propagation/test_tracecontexthttptextformat.py b/opentelemetry-api/tests/context/propagation/test_tracecontexthttptextformat.py
@@ -99,7 +99,6 @@ def test_invalid_trace_id(self):
  },
  )
  self.assertEqual(span_context, trace.INVALID_SPAN_CONTEXT)
- self.assertNotEqual(span_context.span_id, "1234567890123456")
 
  def test_invalid_parent_id(self):
  """If the parent id is invalid, we must ignore the full traceparent header.
@@ -171,8 +170,7 @@ def test_propagate_invalid_context(self):
  self.assertFalse("traceparent" in output)
 
  def test_tracestate_empty_header(self):
- """Do not propagate invalid trace context.
- """
+ """Test tracestate with an additional empty header (should be ignored)"""
  span_context = FORMAT.extract(
  get_as_list,
  {