Fail if key is empty.

open-telemetry · Aug 27, 2019 · ae4f570 · ae4f570
1 parent 938a0b3
commit ae4f570
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/opentelemetry-api/src/opentelemetry/distributedcontext/__init__.py b/opentelemetry-api/src/opentelemetry/distributedcontext/__init__.py
@@ -49,7 +49,7 @@ def __new__(cls, value: str) -> "EntryKey":
 
     @staticmethod
     def create(value: str) -> "EntryKey":
-        if len(value) > 255 or any(c not in PRINTABLE for c in value):
+        if not 0 < len(value) <= 255 or any(c not in PRINTABLE for c in value):
             raise ValueError("Invalid EntryKey", value)
 
         return typing.cast(EntryKey, value)

diff --git a/opentelemetry-api/tests/distributedcontext/test_distributed_context.py b/opentelemetry-api/tests/distributedcontext/test_distributed_context.py
@@ -32,6 +32,10 @@ def test_entry_ttl_unlimited_propagation(self):
 
 
 class TestEntryKey(unittest.TestCase):
+    def test_create_empty(self):
+        with self.assertRaises(ValueError):
+            distributedcontext.EntryKey.create("")
+
     def test_create_too_long(self):
         with self.assertRaises(ValueError):
             distributedcontext.EntryKey.create("a" * 256)