-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle "mixed mode" OT/OTel tracing in OT Bridge #161
Comments
I think this would work out of the box with the straightforward implementation of basically delegating the OT functions to OTel mostly one to one. Or what do you think would break that interaction? |
I don't know how storing of the active span is done in python, but in Go we use the Other scenario was more "interesting" - library A uses Otel and then it calls library B that uses OT. So at this point it would be nice for the library B if the Otel span created by library A was also wrapped and put into the context as an active OT span. That way, an OT span created inside the library B would have a proper parent - a OT span that wraps an Otel span created in library A. The "interesting" part here is that library A uses Otel API, so no OT API is used directly and yet some OT stuff needs to happen too. |
Looking at the OpenTelemetry code, I would implement a scope manager that sets / gets the active Span from the OpenTelemetry tracers (of course, setting is not possible ATM, #154 may help but you may need to add a new setter to the OTel Tracer). EDIT: Regarding the type mismatch: Either you always return a new |
Removing this from milestones for now, @carlosalberto to consider adding for v4. |
* feat(plugin): add http plugin Closes open-telemetry#157 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: integrate vmarchaud recommandations Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: wip revert - gts fix issue on all packages Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: integrate mayurkale22 recommendations Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * ci: gts fix for ci build Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * refactor: add mayurkale22 recommendations Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: integrate bg451 recommendations test: increase coverage fix: attributes requirements from the spec. Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: add missing header and revert scopeManager to private field test: rename some tests fix: copy/paste tests Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: add tests and improve attributes from spec fix parentSpanId instead of parentId from rebase add workaround with got and node12+ (real http call) improve args passed to function (url, options, cb) Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: add mayurkale22 recommendations Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: rebase and remove/replace wrapEmitter to bind Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: add Flarna recommendations fix: add Flarna recommendations fix: tests fix: OC bugs in OT only test: add assertions Allow options object as second argument Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * refactor: simplify propagation usage Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: add Flarna recommandations Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * refactor(test): use ReadableSpan Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * feat: export class/enums for https module Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * refactor: plugin.enable has logger param Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: add license header, rename enum files and refactoring refactor: make integration tests mandatory for ci only remove duplicate tests remove dead comments Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@krnowak brought to my attention the following use case for the OT bridge:
Do we want the OT bridge to support this use case by handling parent-child relationship between the wrapped OT span and the OTel span?
The text was updated successfully, but these errors were encountered: