Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: current Span handling updates #163

Closed
carlosalberto opened this issue Sep 24, 2019 · 1 comment
Closed

API: current Span handling updates #163

carlosalberto opened this issue Sep 24, 2019 · 1 comment
Labels
api Affects the API package. tracing
Milestone
Alpha v0.2

Comments

@carlosalberto
Copy link
Contributor

As part of open-telemetry/opentelemetry-specification#238 we should not set the newly created Span as the current instance for Tracer.start_span().

As part of this, we could also add a Tracer.start_as_current_span() (or with a similar name) method that would essentially do:

def start_as_current_span(self, ..., end_on_exit): # Guess end_on_exit should be optional as well
    span = self.start_span(...)
    return self.use_span(span, end_on_exit)

cc @Oberon00 (whose latest PR I sadly missed - sorry ;( )
@Oberon00 Oberon00 added api Affects the API package. tracing labels Sep 25, 2019
@c24t c24t added this to the Alpha v0.2 milestone Oct 11, 2019
@mauriciovasquezbernal
Copy link
Member

Solved by #198?

@c24t c24t closed this as completed Oct 31, 2019
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@danielkhan @mayurkale22
Improve coverage on AsyncHooksScopeManager (open-telemetry#178)
68d8f9d 
* fix: / update gitignore
.gitignore to ignore .nyc_output

* fix: increase feature coverage on ScopeManager

closes open-telemetry#163

* fix: use strictEqual()

* fix: typo
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@danielkhan
fix: scopemanager initialization in test (open-telemetry#179)
fc74a7f 
* fix: / update gitignore
.gitignore to ignore .nyc_output

* fix: increase feature coverage on ScopeManager

closes open-telemetry#163

* fix: use strictEqual()

* fix: instantiate ScopeManager in beforeEach()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Affects the API package. tracing
Projects
None yet
Milestone
Alpha v0.2
Development

No branches or pull requests
4 participants
@carlosalberto @Oberon00 @mauriciovasquezbernal @c24t