Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate w3c TraceContext validation into CI and tox #202

Closed
toumorokoshi opened this issue Oct 3, 2019 · 1 comment
Closed

Integrate w3c TraceContext validation into CI and tox #202

toumorokoshi opened this issue Oct 3, 2019 · 1 comment
Assignees
Labels
build & infra Issues related to build & infrastructure. sdk Affects the SDK package. tracing
Milestone

Comments

@toumorokoshi
Copy link
Member

There is an external validator to ensure that the TraceContext spec is adhered to:

https://github.com/w3c/trace-context/tree/master/test

We should integrate this as a test that is executed for CI. Probably with a version pinned so we don't randomly break CI as new specifications are added.

@toumorokoshi toumorokoshi self-assigned this Oct 3, 2019
@toumorokoshi toumorokoshi added this to the Beta Release milestone Oct 3, 2019
@Oberon00 Oberon00 added build & infra Issues related to build & infrastructure. sdk Affects the SDK package. tracing labels Oct 10, 2019
@c24t c24t modified the milestones: Beta Release, Alpha v0.2 Oct 11, 2019
@reyang
Copy link
Member

reyang commented Oct 30, 2019

This should have been addressed by @toumorokoshi in #228.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build & infra Issues related to build & infrastructure. sdk Affects the SDK package. tracing
Projects
None yet
Development

No branches or pull requests

4 participants