Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Span setStatus #212

Closed
hectorhdzg opened this issue Oct 9, 2019 · 2 comments
Closed

Add Span setStatus #212

hectorhdzg opened this issue Oct 9, 2019 · 2 comments
Labels
api Affects the API package. duplicate This issue or pull request already exists tracing

Comments

@hectorhdzg
Copy link
Member

Specification mention Span object must have a setStatus method and is currently missing

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/api-tracing.md#set-status

If nothing is preventing us to add this, I will be happy to take care of it
@hectorhdzg hectorhdzg mentioned this issue Oct 9, 2019
Merged
@mauriciovasquezbernal
Copy link
Member

Duplicated of #98?

@Oberon00
Copy link
Member

Closing this in favor of #98.

@Oberon00 Oberon00 added api Affects the API package. duplicate This issue or pull request already exists tracing labels Oct 10, 2019
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@bg451
feat: Add OpenTracing shim (open-telemetry#212)
ede7886 
* checkpoint

* add test for links and attributes

* lint

* comment out binary inject/extract code

* use setAttributes and addLinks

* Adds test for span.finish()

* remove console.log

* respond to comments round 1

* adds missing return

* adds codecov

* fix compile errors checkpoint

* more compile error fixing

* Update packages/opentelemetry-shim-opentracing/src/shim.ts

Co-Authored-By: Mayur Kale <mayurkale@google.com>

* Update packages/opentelemetry-shim-opentracing/src/shim.ts

Co-Authored-By: Mayur Kale <mayurkale@google.com>

* Update packages/opentelemetry-shim-opentracing/src/shim.ts

Co-Authored-By: Mayur Kale <mayurkale@google.com>

* Update packages/opentelemetry-shim-opentracing/src/shim.ts

Co-Authored-By: Mayur Kale <mayurkale@google.com>

* lint

* update readme links

* respond to comments

* Adds tslint.json

* Update license

* respodn to comments

* ftb pt3

* ftb

* adds logger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Affects the API package. duplicate This issue or pull request already exists tracing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Oberon00 @mauriciovasquezbernal @hectorhdzg