Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide unit test framework #28

Closed
Oberon00 opened this issue Jun 25, 2019 · 1 comment
Closed

Decide unit test framework #28

Oberon00 opened this issue Jun 25, 2019 · 1 comment
Labels
meta Related to repo itself, process, community, ...

Comments

@Oberon00
Copy link
Member

I noticed OpenCensus Python used the Python standard library's unit test framework, while OpenTracing uses pytest. Personally I'd prefer pytest, as it lets you write all your assertions with the assert keyword and you don't have to think about importing & using assertEquals vs assertTrue, etc. On the other hand, the stdlib has the (slight?) advantage of not requiring an additional development dependency.

We should decide for a unit test framework.

@Oberon00 Oberon00 added the meta Related to repo itself, process, community, ... label Jun 25, 2019
@Oberon00
Copy link
Member Author

Oberon00 commented Jul 4, 2019

In the meeting on Wed 2019-07-03 we (@c24t, @carlosalberto, @reyang, @Oberon00) decided to start out with the standard library's unit test module. If we find that we are duplicating a lot pytest features ourselves, we might reconsider this decision.

@Oberon00 Oberon00 closed this as completed Jul 4, 2019
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to repo itself, process, community, ...
Projects
None yet
Development

No branches or pull requests

1 participant