Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research separation of patchers and exporters #333

Closed
ocelotl opened this issue Dec 12, 2019 · 1 comment
Closed

Research separation of patchers and exporters #333

ocelotl opened this issue Dec 12, 2019 · 1 comment

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Dec 12, 2019 •
edited
Loading

Right now, the ext directory contains code that implements functionality for automatic patching of several third-party projects that integrate with this project. Inside this directory it can also be found exporters that integrate in a similar way.

It would be convenient to have a uniform interface for these components and to make them integrate with this project through like standard entry points instead of having them imported statically.

This is closely related to #300 since the separation proposed here can benefit the auto-instrumentation efforts by allowing this project to dynamically load the patchers that do auto-instrumentation instead of having them all hard coded in the sitecustomize.py file.
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Dec 13, 2019
@ocelotl
Dynamically load patchers
8425f8f 
Fixes open-telemetry#333
@ocelotl ocelotl mentioned this issue Dec 13, 2019
Closed
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Dec 18, 2019
@ocelotl
Dynamically load patchers
cb5c8e1 
Fixes open-telemetry#333
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Dec 18, 2019
@ocelotl
Dynamically load patchers
17e3faf 
Fixes open-telemetry#333
@ocelotl
Copy link
Contributor Author

ocelotl commented Dec 18, 2019

Is getting a bit complicated to keep this issue separated from #300. I'll be merging the PR branch that corresponds to this issue into the PR branch of #300.

@ocelotl ocelotl closed this as completed Dec 18, 2019
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 3, 2020
@ocelotl
Dynamically load patchers
606a974 
Fixes open-telemetry#333
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 7, 2020
@ocelotl
Dynamically load patchers
7ea2fff 
Fixes open-telemetry#333
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 7, 2020
@ocelotl
Dynamically load patchers
2933761 
Fixes open-telemetry#333
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 27, 2020
@ocelotl
Dynamically load patchers
95b4134 
Fixes open-telemetry#333
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 3, 2020
@ocelotl
Dynamically load patchers
d19a486 
Fixes open-telemetry#333
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 5, 2020
@ocelotl
Dynamically load patchers
da0aeba 
Fixes open-telemetry#333
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 17, 2020
@ocelotl
Dynamically load patchers
1ef715e 
Fixes open-telemetry#333
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 19, 2020
@ocelotl
Dynamically load patchers
2109e94 
Fixes open-telemetry#333
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 20, 2020
@ocelotl
Dynamically load patchers
589598f 
Fixes open-telemetry#333
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 24, 2020
@ocelotl
Dynamically load patchers
6ad0b0b 
Fixes open-telemetry#333
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 28, 2020
@ocelotl
Dynamically load patchers
26a12a3 
Fixes open-telemetry#333
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 2, 2020
@ocelotl
Dynamically load patchers
f061625 
Fixes open-telemetry#333
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 16, 2020
@ocelotl
Dynamically load patchers
5bcd008 
Fixes open-telemetry#333
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22
fix(exporter-zipkin): use hrTimeToMicroseconds for zipkin timestamp a… (
7249661 
open-telemetry#333)

* fix(exporter-zipkin): use hrTimeToMicroseconds for zipkin timestamp and duration

* fix: review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 333 ocelotl/opentelemetry-python
1 participant
@ocelotl