Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename test objects to avoid pytest warnings #3779

Closed
xrmx opened this issue Mar 13, 2024 · 1 comment · Fixed by #3823
Closed

Rename test objects to avoid pytest warnings #3779

xrmx opened this issue Mar 13, 2024 · 1 comment · Fixed by #3823
Assignees
Labels
bug Something isn't working

Comments

@xrmx
Copy link
Contributor

xrmx commented Mar 13, 2024

Describe your environment

Steps to reproduce

tox -e py311-opentelemetry-api

You can substitute py311 with whatever python version you have locally.

What is the expected behavior?

No pytest warnings

What is the actual behavior?

opentelemetry-api/tests/logs/test_proxy.py:35
  /home/rm/src/opentelemetry-python/opentelemetry-api/tests/logs/test_proxy.py:35: PytestCollectionWarning: cannot collect test class 'TestLogger' because it has a __init__ constructor (from: opentelemetry-api/tests/logs/test_proxy.py)
    class TestLogger(_logs.NoOpLogger):

opentelemetry-api/tests/trace/test_globals.py:10
  /home/rm/src/opentelemetry-python/opentelemetry-api/tests/trace/test_globals.py:10: PytestCollectionWarning: cannot collect test class 'TestSpan' because it has a __init__ constructor (from: opentelemetry-api/tests/trace/test_globals.py)
    class TestSpan(trace.NonRecordingSpan):

opentelemetry-api/tests/trace/test_proxy.py:49
  /home/rm/src/opentelemetry-python/opentelemetry-api/tests/trace/test_proxy.py:49: PytestCollectionWarning: cannot collect test class 'TestSpan' because it has a __init__ constructor (from: opentelemetry-api/tests/trace/test_proxy.py)
    class TestSpan(NonRecordingSpan):

Additional context

@xrmx xrmx added the bug Something isn't working label Mar 13, 2024
@geetikabatra
Copy link
Contributor

Can I take this up?

geetikabatra pushed a commit to geetikabatra/opentelemetry-python that referenced this issue Mar 28, 2024
This PR removes unneccesary warnings

Fixes: open-telemetry#3779
geetikabatra pushed a commit to geetikabatra/opentelemetry-python that referenced this issue Mar 28, 2024
This PR removes unneccesary warnings

Fixes: open-telemetry#3779
geetikabatra added a commit to geetikabatra/opentelemetry-python that referenced this issue May 3, 2024
    This PR removes unneccesary warnings

    Fixes: open-telemetry#3779
geetikabatra added a commit to geetikabatra/opentelemetry-python that referenced this issue May 3, 2024
    This PR removes unneccesary warnings

    Fixes: open-telemetry#3779
geetikabatra added a commit to geetikabatra/opentelemetry-python that referenced this issue May 3, 2024
    This PR removes unneccesary warnings

    Fixes: open-telemetry#3779
ocelotl pushed a commit that referenced this issue May 6, 2024
This PR removes unneccesary warnings

    Fixes: #3779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants