py.typed not included in wheels #4113
Labels
bug
Something isn't working
Comments
kjagiello
added a commit
to kjagiello/opentelemetry-python
that referenced
this issue
Sep 1, 2024
As defined in PEP 420, the py.typed marker files for namespace packages should be placed "in the submodules of the namespace, to avoid conflicts and for clarity". In commit 732ea8a, the markers were added to the subpackage roots, which serves no purpose. This changeset addresses all marker-related issues in this repository. A summary of the changes: - Removed the unnecessary py.typed markers from the subpackage roots. - Removed the markers at the root of the namespaces. - Added the missing marker to the prometheus exporter. Fixes open-telemetry#4113. - Added the missing marker in opentelemetry._events. - Removed the accidentally reintroduced jaeger exporters, which were originally removed in commit 1625b35.
kjagiello
added a commit
to kjagiello/opentelemetry-python
that referenced
this issue
Sep 1, 2024
As defined in PEP 561, the py.typed marker files for namespace packages should be placed "in the submodules of the namespace, to avoid conflicts and for clarity". In commit 732ea8a, the markers were added to the subpackage roots, which serves no purpose. This changeset addresses all marker-related issues in this repository. A summary of the changes: - Removed the unnecessary py.typed markers from the subpackage roots. - Removed the markers at the root of the namespaces. - Added the missing marker to the prometheus exporter. Fixes open-telemetry#4113. - Added the missing marker in opentelemetry._events. - Removed the accidentally reintroduced jaeger exporters, which were originally removed in commit 1625b35.
kjagiello
added a commit
to kjagiello/opentelemetry-python
that referenced
this issue
Sep 1, 2024
As defined in PEP 561, the py.typed marker files for namespace packages should be placed "in the submodules of the namespace, to avoid conflicts and for clarity". In commit 732ea8a, the markers were added to the subpackage roots, which serves no purpose. This changeset addresses all marker-related issues in this repository. A summary of the changes: - Removed the unnecessary py.typed markers from the subpackage roots. - Removed the markers at the root of the namespaces. - Added the missing marker to the prometheus exporter. Fixes open-telemetry#4113. - Added the missing marker to opentelemetry._events. - Removed the accidentally reintroduced jaeger exporters, which were originally removed in commit 1625b35.
kjagiello
added a commit
to kjagiello/opentelemetry-python
that referenced
this issue
Sep 1, 2024
As defined in PEP 561, the py.typed marker files for namespace packages should be placed "in the submodules of the namespace". In commit 732ea8a, the markers were added to the subpackage roots, which serves no purpose. This changeset addresses all marker-related issues in this repository. A summary of the changes: - Removed the unnecessary py.typed markers from the subpackage roots. - Added the missing marker to the prometheus exporter. Fixes open-telemetry#4113. - Added the missing marker to opentelemetry._events. - Removed the accidentally reintroduced jaeger exporters, which were originally removed in commit 1625b35.
kjagiello
added a commit
to kjagiello/opentelemetry-python
that referenced
this issue
Sep 1, 2024
As defined in PEP 561, the py.typed marker files for namespace packages should be placed "in the submodules of the namespace". In commit 732ea8a, the markers were added to the subpackage roots, which serves no purpose. This changeset addresses all marker-related issues in this repository. A summary of the changes: - Removed the unnecessary py.typed markers from the subpackage roots. - Added the missing marker to the prometheus exporter. Fixes open-telemetry#4113. - Added the missing marker to opentelemetry._events. - Removed the accidentally reintroduced jaeger exporters, which were originally removed in commit 1625b35.
|
I think this was resolved in #4084 included in 1.27 |
|
@jenshnielsen there is a followup PR at #4172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe your environment
OS: ubuntu
Python version: Python 3.12
SDK version: 1.26.0
API version: 1.26.0
What happened?
#3385 added a
py.typedmarker to every subpackage.This marker was added to the subpackage root, but it should stay with the package source code (inside
/src)ie: Instead of exporter/opentelemetry-exporter-prometheus, it should be exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus
Steps to Reproduce
Run mypy with
--strictflag in a project importing fromopentelemetry.exporter.prometheus.Expected Result
Mypy succeeds
Actual Result
Mypy fails with
error: Skipping analyzing "opentelemetry.exporter.prometheus": module is installed, but missing library stubs or py.typed marker [import-untyped]Additional context
No response
Would you like to implement a fix?
Yes
The text was updated successfully, but these errors were encountered: