Add contextvars backport #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
reviewed
Aug 23, 2019
There was a problem hiding this comment.
I wonder: If the app does not already depend on contextvars does it do us any good to use contextvars instead of thread locals? Since the backport does not integrate with asyncio.
EDIT: If we drop 3.4 I'm totally for this but otherwise I see no benefit, since we still need to support TLS context anyway.
|
@Oberon00 That's a fair point, maybe it's better to make this an optional install ( |
|
If it is optional install, then we don't need it. Closing the PR for now. |
|
But what about this? |
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* scope: remove reporting of empty codecov * core: prefix codecov report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.