Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter attributes on lazy event add #1014

Merged
merged 5 commits into from
Aug 20, 2020
Merged

Filter attributes on lazy event add #1014

merged 5 commits into from
Aug 20, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Aug 18, 2020

Part of [#928] and solves [#1013].

@lzchen lzchen requested a review from a team August 18, 2020 17:11
aabmass
aabmass approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py Outdated Show resolved Hide resolved
codeboten
codeboten approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, just a non-blocking question.

opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py Show resolved Hide resolved
@lzchen lzchen merged commit ee094c2 into open-telemetry:master Aug 20, 2020
@lzchen lzchen deleted the events branch August 20, 2020 00:24
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@vmarchaud
feat(metrics): use MetricDescriptor to determine aggregator open-tele…
16ae2a7 
…metry#989 (open-telemetry#1014)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzchen @codeboten @aabmass