Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pytest config to pyproject.toml #1086

Merged
merged 3 commits into from
Sep 16, 2020

Conversation

ffe4
Copy link
Contributor

@ffe4 ffe4 commented Sep 9, 2020

Description

Moves pytest configuration from pytest.ini to pyproject.toml

Since version 6.0, pytest supports configuration via the pyproject.toml file. I think it would be nice to get rid of some files in the repo's root directory, so I can also look into moving other configuration if this is something we want. Pretty much every tool has at least an open ticket for pyproject.toml support by now.

How Has This Been Tested?

I ran tox -f py38-api to make sure the output looks the same.

Since version 6.0, pytest supports configuration via the pyproject.toml file.
Migrating has the advantages of centralized configuration and fewer files in the repo's root dir.
@ffe4 ffe4 requested a review from a team September 9, 2020 13:02
@ffe4
Copy link
Contributor Author

ffe4 commented Sep 9, 2020

Nevermind, it seems pytest>=6 is not compatible with Python 3.4

@ffe4 ffe4 closed this Sep 9, 2020
@ffe4
Copy link
Contributor Author

ffe4 commented Sep 15, 2020

Reopening since the issue should be solved after #1099

@ffe4 ffe4 reopened this Sep 15, 2020
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, less files is always better!

@lzchen lzchen merged commit eaa7764 into open-telemetry:master Sep 16, 2020
@ffe4 ffe4 deleted the migrate-pytest-config branch September 17, 2020 07:13
alertedsnake pushed a commit to alertedsnake/opentelemetry-python that referenced this pull request Sep 25, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
…try#1086)

* chore: send a welcome message to first time contributors

* chore: fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants