Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jaeger exporter report instrumentation info #1098

Merged
merged 5 commits into from
Sep 15, 2020
Merged

Jaeger exporter report instrumentation info #1098

merged 5 commits into from
Sep 15, 2020

Conversation

dengliming
Copy link
Member

Fixes #1092

@dengliming dengliming requested a review from a team September 11, 2020 16:15
codeboten
codeboten approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

Once this issue is addressed #1022, we should make sure to refactor this code to use generated strings for the keys in this PR.

@lzchen lzchen merged commit 071b1b3 into open-telemetry:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@codeboten codeboten codeboten approved these changes

@owais owais owais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jaeger exporter must report instrumentation info
4 participants
@dengliming @owais @codeboten @lzchen