Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use is_recording flag in asgi, pyramid, aiohttp instrumentation #1142

Merged
merged 15 commits into from
Sep 22, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Sep 21, 2020

Part of #1057

@lzchen lzchen requested a review from a team September 21, 2020 19:12
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the change!

@lzchen lzchen merged commit d8edd50 into open-telemetry:master Sep 22, 2020
@lzchen lzchen deleted the asgi branch September 22, 2020 17:30
alertedsnake pushed a commit to alertedsnake/opentelemetry-python that referenced this pull request Sep 25, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants