Added ability to extract span attributes from falcon request objects. #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
falcon-request-attrs
branch
4 times, most recently
from
05942ea to
97dc1d4
Compare
owais
force-pushed
the
falcon-request-attrs
branch
4 times, most recently
from
7739425 to
2bc7693
Compare
OTEL_PYTHON_FALCON_TRACED_REQUEST_ATTRS env var can be set to a command separated list of attributes names that will be extracted from Falcon's request object and set as attributes on spans.
owais
force-pushed
the
falcon-request-attrs
branch
from
2bc7693 to
bd1eead
Compare
|
This seems like pretty cool functionality. Should we have a generic way of extracting custom attributes from any instrumentation request and populate the span attributes with? |
|
I'm gonna send similar PR for Tornado soon. Perhaps we should look if we can have shared functionality after that. I think >3 is nice number to start abstracting away :) At least we could have a shared utility function to extract attributes and set on a span. |
lzchen
approved these changes
Sep 29, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OTEL_PYTHON_FALCON_TRACED_REQUEST_ATTRS env var can be set to a command
separated list of attributes names that will be extracted from Falcon's
request object and set as attributes on spans.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: