-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagator Class [POC for review] #121
Closed
toumorokoshi
wants to merge
10
commits into
open-telemetry:master
from
toumorokoshi:feature/propagators-object
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a8dc9b3
Changed to the propagator API
toumorokoshi aab575f
Addressing feedback
toumorokoshi 37f57b6
re-adding missing BinaryFormat API.
toumorokoshi 1f37b2a
Removing mention of UnifiedContext
toumorokoshi dc063a2
Fixing sphinx warnings
toumorokoshi c031df3
fixing type annotations for sphinx
toumorokoshi 3d8dbde
reverting type changes on class attributes
toumorokoshi 4e55a5e
Authoring a propagator class
toumorokoshi b755b0c
Fixing some errors
toumorokoshi e4d43cb
Moving imports to relative
toumorokoshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 0 additions & 4 deletions
4
opentelemetry-api/src/opentelemetry/context/propagation/__init__.py
This file was deleted.
Oops, something went wrong.
60 changes: 0 additions & 60 deletions
60
opentelemetry-api/src/opentelemetry/context/propagation/binaryformat.py
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
opentelemetry-api/src/opentelemetry/distributedcontext/propagation/__init__.py
This file was deleted.
Oops, something went wrong.
114 changes: 0 additions & 114 deletions
114
opentelemetry-api/src/opentelemetry/distributedcontext/propagation/httptextformat.py
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably off-topic, but: You are injecting the headers after the request was sent here, and into the response headers instead of the request headers.
I also wonder if we should automatically fall back to
setter.__setitem__
ifnot callable(setter)
. Requiring users to pass dunder methods is a bit arcane.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry yes, good point. Will fix that.
defaulting to setitem is a good idea. Just requires someone to write a wrapper object if that doesn't already exist. A bound callable isn't a bad idea either.
I'll file an issue and pick that up in another PR.